-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dashboard: Add view for PR runs #1
Comments
PR #23 |
FYI, I think the reason those run counts are 0 is that the name of the test does not exactly match--in the PR, there’s an additional descriptor, e.g.: kata-containers-ci-on-push / run-k8s-tests-on-ppc64le So I think it technically is a different test (?), but I’ll investigate further. |
Good catch! The test is defined here btw: https://github.com/kata-containers/kata-containers/blob/main/.github/workflows/run-k8s-tests-on-ppc64le.yaml#L26 So the Github API returns [1], but the actual test name is [2], correct? [1] kata-containers-ci-on-push / run-k8s-tests-on-ppc64le An idea: could it be that if you have a test |
To try and close the loop on this. Yes, you're essentially correct, but a couple things to note. I think the original issue of some run counts being precisely 0 was the fact that we were using the list of jobs from the Nightly Runs when looking up the PR jobs. But now we lookup all of the jobs from the PRs, rather than trying to cross-reference with the Nightly Run jobs. So that specific discrepancy is resolved. However, you are still correct that we do have cases where, because the run fails at an intermediate workflow, it will list a / b and then, on a separate row for runs that passed the intermediate step, a / b / c. To my understanding, this is not really a problem, and those should still be displayed as separate rows with separate counts, as they currently are. (I suppose we could aggregate them by incrementing the fails for every downstream workflow, but that would make it seem like the downstream workflow itself failed, but in reality it was simply never reached.). But happy to discuss. |
Added a script that fetches PR data and created a separate view on the dashboard. Fixes kata-containers#1 Signed-off-by: Anna Finn <[email protected]>
Added a script that fetches PR data and created a separate view on the dashboard. Fixes kata-containers#1 Signed-off-by: Anna Finn <[email protected]>
Just dump PR into official repo |
Added a script that fetches PR data and created a separate view on the dashboard. Fixes kata-containers#1 Signed-off-by: Anna Finn <[email protected]>
Added a script that fetches PR data and created a separate view on the dashboard. Fixes kata-containers#1 Signed-off-by: Anna Finn <[email protected]>
Added a script that fetches PR data and created a separate view on the dashboard. Tweaked dotenv require. Fixes kata-containers#1 Signed-off-by: Anna Finn <[email protected]>
Added a script that fetches PR data and created a separate view on the dashboard. Tweaked dotenv require. Fixes kata-containers#1 Signed-off-by: Anna Finn <[email protected]>
Added a script that fetches PR data and created a separate view on the dashboard. Tweaked dotenv require. Fixes kata-containers#1 Signed-off-by: Anna Finn <[email protected]>
Added a script that fetches PR data and created a separate view on the dashboard. Tweaked dotenv require. Fixes kata-containers#1 Signed-off-by: Anna Finn <[email protected]>
Added a script that fetches PR data and created a separate view on the dashboard. Tweaked dotenv require. Fixes kata-containers#1 Signed-off-by: Anna Finn <[email protected]>
Added a script that fetches PR data and created a separate view on the dashboard. Tweaked dotenv require. Fixes kata-containers#1 Signed-off-by: Anna Finn <[email protected]>
Acceptance criteria:
The text was updated successfully, but these errors were encountered: