Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: Add view for PR runs #1

Open
1 task
sprt opened this issue Sep 26, 2024 · 5 comments
Open
1 task

dashboard: Add view for PR runs #1

sprt opened this issue Sep 26, 2024 · 5 comments

Comments

@sprt
Copy link
Collaborator

sprt commented Sep 26, 2024

Acceptance criteria:

  • Implement a tabbing mechanism where the new tab has the same view as currently, only listing PR run results (last 10 merged PRs) instead of nightly run results
@sprt sprt converted this from a draft issue Sep 26, 2024
@afinn12
Copy link
Contributor

afinn12 commented Oct 9, 2024

PR #23

image

@chris-krenz
Copy link

FYI, I think the reason those run counts are 0 is that the name of the test does not exactly match--in the PR, there’s an additional descriptor, e.g.:

kata-containers-ci-on-push / run-k8s-tests-on-ppc64le
vs.
kata-containers-ci-on-push / run-k8s-tests-on-ppc64le / run-k8s-tests (qemu, kubeadm)

So I think it technically is a different test (?), but I’ll investigate further.

Image

Image

@sprt
Copy link
Collaborator Author

sprt commented Oct 16, 2024

Good catch! The test is defined here btw: https://github.com/kata-containers/kata-containers/blob/main/.github/workflows/run-k8s-tests-on-ppc64le.yaml#L26

So the Github API returns [1], but the actual test name is [2], correct?

[1] kata-containers-ci-on-push / run-k8s-tests-on-ppc64le
[2] kata-containers-ci-on-push / run-k8s-tests-on-ppc64le / run-k8s-tests (qemu, kubeadm)

An idea: could it be that if you have a test a / b / c, the Github API returns a / b if c couldn't be executed for some reason? Look at how the test is defined here, maybe the if or the needs aren't satisfied?
https://github.com/kata-containers/kata-containers/blob/69509eff33f7c18c143628639f5a8998f3beab76/.github/workflows/ci.yaml#L200-L202

@chris-krenz
Copy link

To try and close the loop on this. Yes, you're essentially correct, but a couple things to note.

I think the original issue of some run counts being precisely 0 was the fact that we were using the list of jobs from the Nightly Runs when looking up the PR jobs. But now we lookup all of the jobs from the PRs, rather than trying to cross-reference with the Nightly Run jobs. So that specific discrepancy is resolved.

However, you are still correct that we do have cases where, because the run fails at an intermediate workflow, it will list a / b and then, on a separate row for runs that passed the intermediate step, a / b / c.

To my understanding, this is not really a problem, and those should still be displayed as separate rows with separate counts, as they currently are. (I suppose we could aggregate them by incrementing the fails for every downstream workflow, but that would make it seem like the downstream workflow itself failed, but in reality it was simply never reached.). But happy to discuss.

afinn12 added a commit to a1icja/kata-containers.github.io that referenced this issue Nov 7, 2024
Added a script that fetches PR data and created a separate view on the dashboard.

Fixes kata-containers#1

Signed-off-by: Anna Finn <[email protected]>
afinn12 added a commit to a1icja/kata-containers.github.io that referenced this issue Nov 7, 2024
Added a script that fetches PR data and created a separate view on the dashboard.

Fixes kata-containers#1

Signed-off-by: Anna Finn <[email protected]>
@sprt
Copy link
Collaborator Author

sprt commented Nov 13, 2024

Just dump PR into official repo

afinn12 added a commit to a1icja/kata-containers.github.io that referenced this issue Nov 18, 2024
Added a script that fetches PR data and created a separate view on the dashboard.

Fixes kata-containers#1

Signed-off-by: Anna Finn <[email protected]>
afinn12 added a commit to a1icja/kata-containers.github.io that referenced this issue Nov 22, 2024
Added a script that fetches PR data and created a separate view on the dashboard.

Fixes kata-containers#1

Signed-off-by: Anna Finn <[email protected]>
afinn12 added a commit to a1icja/kata-containers.github.io that referenced this issue Dec 6, 2024
Added a script that fetches PR data and created a separate view on the dashboard.
Tweaked dotenv require.

Fixes kata-containers#1

Signed-off-by: Anna Finn <[email protected]>
afinn12 added a commit to a1icja/kata-containers.github.io that referenced this issue Dec 6, 2024
Added a script that fetches PR data and created a separate view on the dashboard.
Tweaked dotenv require.

Fixes kata-containers#1

Signed-off-by: Anna Finn <[email protected]>
afinn12 added a commit to a1icja/kata-containers.github.io that referenced this issue Dec 6, 2024
Added a script that fetches PR data and created a separate view on the dashboard.
Tweaked dotenv require.

Fixes kata-containers#1

Signed-off-by: Anna Finn <[email protected]>
afinn12 added a commit to a1icja/kata-containers.github.io that referenced this issue Dec 6, 2024
Added a script that fetches PR data and created a separate view on the dashboard.
Tweaked dotenv require.

Fixes kata-containers#1

Signed-off-by: Anna Finn <[email protected]>
afinn12 added a commit to a1icja/kata-containers.github.io that referenced this issue Dec 6, 2024
Added a script that fetches PR data and created a separate view on the dashboard.
Tweaked dotenv require.

Fixes kata-containers#1

Signed-off-by: Anna Finn <[email protected]>
afinn12 added a commit to a1icja/kata-containers.github.io that referenced this issue Dec 6, 2024
Added a script that fetches PR data and created a separate view on the dashboard.
Tweaked dotenv require.

Fixes kata-containers#1

Signed-off-by: Anna Finn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants