Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell escaping isn't right #7

Open
rmanthorpe opened this issue Oct 23, 2019 · 0 comments
Open

Shell escaping isn't right #7

rmanthorpe opened this issue Oct 23, 2019 · 0 comments

Comments

@rmanthorpe
Copy link
Contributor

rmanthorpe commented Oct 23, 2019

Shell escaping isn't right. This is also part of the problem with using regex as it stands. To see the problem, try greping for some regex! I think it might be best not to use shell-quote and just do a minimal quoting ourselves. I think a rough idea of how to do this better is:

  • On Linux & Mac: Surround by double quotes then we just need to handle $, ` , " and \.
  • On Windows: Surround by double quotes and I don't think you need to escape anything.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant