Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed Test when port in use #28

Open
TBSliver opened this issue Aug 4, 2016 · 3 comments
Open

Failed Test when port in use #28

TBSliver opened this issue Aug 4, 2016 · 3 comments

Comments

@TBSliver
Copy link

TBSliver commented Aug 4, 2016

The test t/10_child_exit.t fails if something is already using port 5000
@atoomic
Copy link

atoomic commented Dec 5, 2019

I had the same issue where port :5000 was already used by a docker container
at least the unit test should check that the port is already used and skip if that's the case

maybe also try to use a less common port?

@kazeburo
Copy link
Owner

kazeburo commented Dec 6, 2019

I see it.
It should use Test::TCP.

kazeburo added a commit that referenced this issue Dec 6, 2019
@kazeburo
use empty_port #28
21c8473
@kazeburo
Copy link
Owner

kazeburo commented Dec 6, 2019

I released version 0.48.

kazeburo added a commit that referenced this issue Dec 6, 2019
@kazeburo
Checking in changes prior to tagging of version 0.49.
ddf2587 
Changelog diff is:

diff --git a/Changes b/Changes
index 7c091d3..a118034 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,10 @@ Revision history for Perl extension Gazelle

 {{$NEXT}}

+0.49 2019-12-06T15:34:53Z
+
+ - Fix test use port 5000. #28
+
 0.48 2018-03-05T00:05:15Z

  - remove Try::Tiny deps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kazeburo @atoomic @TBSliver