Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing factor of two in simulated noise #55

Closed
tsunhopang opened this issue Dec 19, 2023 · 0 comments · Fixed by #56
Closed

Missing factor of two in simulated noise #55

tsunhopang opened this issue Dec 19, 2023 · 0 comments · Fixed by #56
Assignees

Comments

@tsunhopang
Copy link
Collaborator

In lines 384 and 385 in jim/src/jimgw /detector.py, the variance of the real part or the imaginary part of the noise should have half of the full variance [1].

Therefore, the line should be

noise_real = jax.random.normal(key, shape=freqs.shape) * jnp.sqrt(var / 2.)
noise_imag = jax.random.normal(subkey, shape=freqs.shape) * jnp.sqrt(var / 2.)

[1] https://en.wikipedia.org/wiki/Complex_normal_distribution

@kazewong kazewong self-assigned this Dec 26, 2023
@kazewong kazewong linked a pull request Dec 26, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants