Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SingleEventRun requires path for injection #92

Closed
thomasckng opened this issue Jul 12, 2024 · 3 comments
Closed

SingleEventRun requires path for injection #92

thomasckng opened this issue Jul 12, 2024 · 3 comments
Assignees
@thomasckng

Comments

@thomasckng
Copy link
Collaborator

SingleEventRun requires path for injection, which is not necessary.
@kazewong
Copy link
Owner

Do you mean the instantiation of path here in the run is not necessary?

jim/src/jimgw/single_event/runManager.py

Line 68 in 94c34db

path: str

@thomasckng
Copy link
Collaborator Author

For injection, the path is not used anywhere I think.

@thomasckng thomasckng moved this to In Progress in Jim-v1.0.0 Jul 23, 2024
@thomasckng thomasckng self-assigned this Jul 23, 2024
@thomasckng thomasckng moved this from In Progress to Done in Jim-v1.0.0 Jul 23, 2024
@thomasckng
Copy link
Collaborator Author

Solved with #103.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomasckng thomasckng

Labels
None yet
Projects
Jim-v1.0.0
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kazewong @thomasckng