Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up tests #3

Open
kbmorales opened this issue Sep 17, 2020 · 1 comment
Open

Set up tests #3

kbmorales opened this issue Sep 17, 2020 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@kbmorales
Copy link
Owner

We need tests for the R package set up with testthat

Ones in particular that would be super useful:

  1. Check status of download URLs for raw data files to ensure they still return a 200 status code before attempting to download
  2. Checking number of rows before and after joins to ensure join duplication does not occur
  3. Ensure that coercion of variables in ppp_clean does not lose information (e.g., turning LoanAmount into a double doesn't turn some useful character data into a NA
@kbmorales kbmorales added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 17, 2020
@jimrothstein
Copy link

  1. Status code, from the documentation for download.file() returns 0, not 200 ... if successful.

Would you consider https://httr.r-lib.org/ for downloading data; this has nice stop_for_status() to check response code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jimrothstein @kbmorales