Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result descriptions are being used for filtering #1

Open
russelldavis opened this issue Jul 18, 2020 · 2 comments
Open

Result descriptions are being used for filtering #1

russelldavis opened this issue Jul 18, 2020 · 2 comments
Assignees

Comments

@russelldavis
Copy link

russelldavis commented Jul 18, 2020

First of all, thanks for this extension! It's exactly what I was looking for.

So the issue is, each result in the list has a description like "Module at line: 1", and those descriptions are being used for filtering. So if I type in "line", I'll get a bunch of results that don't actually have "line" in their name, but they match "line" in the description text.

This also results in even stranger matches due to the fuzzy filtering. If I search for "main", it will show a bunch of arbitrary methods, because it's matching on individual letters, shown in brackets here: "[M]ethod [a]t lines 39 - 44 [in] Foo"

@kbysiec
Copy link
Owner

kbysiec commented Jul 24, 2020

Hi! Thank you for this issue. I am very happy the extension is helpful.

The API for quick pick is pretty limited but I will think a little and try to implement some custom filter mechanism next week (currently I do not have access to my computer).

The best option would be to keep the name of the item kind only for information but allow at the same time to narrow the results using filter phrase.

I will do my best to implement something what will fix this problem.

I will keep you informed.

Thanks.

@kbysiec kbysiec self-assigned this Jul 25, 2020
@kbysiec
Copy link
Owner

kbysiec commented Sep 2, 2020

Unfortunately, as far as I know, the current API is not sufficient to implement custom filtering ☹️ I will keep it on track and in case anything changes I will come back to the issue and implement some custom filtering logic.

@kbysiec kbysiec closed this as completed Sep 2, 2020
@kbysiec kbysiec added on hold enhancement New feature or request feature labels Sep 2, 2020
@kbysiec kbysiec reopened this Sep 3, 2020
@kbysiec kbysiec removed the enhancement New feature or request label Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants