Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate the Recorder from the Streamer #11

Open
mkristofic opened this issue Jan 4, 2020 · 0 comments
Open

Separate the Recorder from the Streamer #11

mkristofic opened this issue Jan 4, 2020 · 0 comments
Assignees
@mkristofic

Comments

@mkristofic
Copy link
Collaborator

Streamer is currently dependent on the Recorder class - this should not be the case. Both Recorder and Streamer should be instantiated inside the client script.
@mkristofic mkristofic self-assigned this Jan 4, 2020
mkristofic added a commit that referenced this issue Jan 4, 2020
@mkristofic
#11 Recorder separated from the Streamer
8464dba 
Streamer no longer depends on the Recorder class. In the constructor, Streamer get the Recorder object and no longer creates it. Instead, the client script creates the recorder object and passed it to the Streamer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkristofic mkristofic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mkristofic