You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The results of our ZCAM implementation are slightly different from the official ZCAM examples in the supplementary document. For example, the paper provides the following values for Example 1 (chromatically adapted to D65 using Luxpy's implementation of CAT02, because we don't support chromatic adaptation yet):
I've reached out to the authors for clarification, but I haven't gotten an answer for the discrepancies and it appears that they're not willing to provide source code for the reference implementation.
This is probably related to D65 adaptation because the example inputs are not relative to D65. As such, it's unlikely to affect our primary use case where all colors come from sRGB and thus do not need adaptation, but it's still worth investigating.
Adapted XYZ values for Example 1 (colorio, ASTM D65, CAT02, average surround, La = 264): 182.25997236, 206.57412429, 231.18612283
The text was updated successfully, but these errors were encountered:
All sample XYZ values have been adapted using colorio's implementation
of CAT02, with F values chosen to match the given surround and L_a
matching the one used for ZCAM.
The paper appears to have the wrong L_a and Y_b values for example #3.
Changing them to match #1 and #2 fixes the tests.
The paper also gives an odd value for hue angle in #5: 389.7720 degrees,
likely caused by unconditionally adding 360 to make the angle positive.
Subtracting 360 makes the test pass.
Closes#3.
By adapting the sample inputs with CAT02 parameters that match the example viewing conditions and leaving the reference white unadapted, our results are now much closer to the examples, but still not exactly the same.
The results of our ZCAM implementation are slightly different from the official ZCAM examples in the supplementary document. For example, the paper provides the following values for Example 1 (chromatically adapted to D65 using Luxpy's implementation of CAT02, because we don't support chromatic adaptation yet):
Our results:
I've reached out to the authors for clarification, but I haven't gotten an answer for the discrepancies and it appears that they're not willing to provide source code for the reference implementation.
This is probably related to D65 adaptation because the example inputs are not relative to D65. As such, it's unlikely to affect our primary use case where all colors come from sRGB and thus do not need adaptation, but it's still worth investigating.
Adapted XYZ values for Example 1 (colorio, ASTM D65, CAT02, average surround, La = 264):
182.25997236, 206.57412429, 231.18612283
The text was updated successfully, but these errors were encountered: