Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataTask that is similar to imageTask #784

Open
larryonoff opened this issue May 20, 2024 · 2 comments
Open

Add dataTask that is similar to imageTask #784

larryonoff opened this issue May 20, 2024 · 2 comments
Labels

Comments

@larryonoff
Copy link
Contributor

Hello!

Our application currently uses Nuke for image and video caching.

We want to add video streaming capabilities (video files are relatively small). We've implemented a solution that uses ImageTask.previews with a custom video decoder, which always decode partially downloaded. This solution uses ImageTask.previews.

However, I believe it would be better to have a dedicated feature similar to ImageTask.previews, like DataTask and DataTask.partialData, which would handle and report partially downloaded data along with its response.

Let me know if there's anything more specific you need help with!

@kean kean added the feature label May 20, 2024
@kean
Copy link
Owner

kean commented May 26, 2024

Hey,

We want to add video streaming capabilities (video files are relatively small). We've implemented a solution that uses ImageTask.previews with a custom video decoder, which always decode partially downloaded. This solution uses ImageTask.previews.

It is a perfectly acceptable solution. ImageResponse is designed to hold data, and it is used this way in other scenarios as well, for example, for rendering animated images.

However, I believe it would be better to have a dedicated feature similar to ImageTask.previews, like DataTask and DataTask.partialData,

I considered this, but the public API in Nuke is already so large that I decided to keep the data support to the bare minimum, intentionally so.

@larryonoff
Copy link
Contributor Author

I considered this, but the public API in Nuke is already so large that I decided to keep the data support to the bare minimum, intentionally so.

Ideally, it would be great if your library supported video streaming and large videos. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants