Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Twirp protocol v7 #63

Open
marioizquierdo opened this issue Oct 30, 2020 · 2 comments
Open

Implement Twirp protocol v7 #63

marioizquierdo opened this issue Oct 30, 2020 · 2 comments
Assignees
@keathley

Comments

@marioizquierdo
Copy link

Changes required to implement the new protocol:

  • Error code resource_exhausted should map to 429 (instead of 403).
  • Allow any arbitrary URL prefixes instead of forcing the "/twirp".

See Protocol v7 differences and the Go implementation v7.0.0 release notes for details.
@keathley keathley self-assigned this Oct 30, 2020
@keathley
Copy link
Owner

Thanks, @marioizquierdo. This has been on my list for a bit. I'm going to try to take a look soon

@marioizquierdo
Copy link
Author

btw, I really like the twirp-elixir implementation. I'm surprised how well it maps all the Twirp concepts to the Elixir style 💯

fishtreesugar added a commit to fishtreesugar/twirp-elixir that referenced this issue Oct 11, 2021
@fishtreesugar
change resource_exhausted error status code to 429
518fc3b 
part of Twirp protocol v7 keathley#63
@fishtreesugar fishtreesugar mentioned this issue Oct 11, 2021
Merged
@zillou zillou mentioned this issue Jan 13, 2022
Merged
zillou added a commit to zillou/twirp-elixir that referenced this issue Jan 14, 2022
@zillou
change resource_exhausted error status code to 429 (#2)
4c7f743 
part of Twirp protocol v7 keathley#63
Co-authored-by: FTS <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keathley keathley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marioizquierdo @keathley