Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing quotes for interceptor's TLS-related env vars #663

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

jkremser
Copy link
Contributor

The env vars were not quoted which ended up in ports not being quoted and helm chart was not installable.

 {{ .. | quote }}

.. would also work, but this way it's consistent w/ the other variables in this file

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Reproduction of the issue, this pr fixes:

helm upgrade -i http-add-on . --namespace keda  --set crds.install=false --set interceptor.tls.enabled=true
Release "http-add-on" does not exist. Installing it now.
Error: 1 error occurred:
	* Deployment in version "v1" cannot be handled as a Deployment: json: cannot unmarshal number into Go struct field EnvVar.spec.template.spec.containers.env.value of type string

@jkremser jkremser requested a review from a team as a code owner July 16, 2024 12:31
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik zroubalik merged commit 5d6d5d1 into kedacore:main Jul 16, 2024
8 checks passed
@jkremser jkremser deleted the add-missing-quotes branch July 16, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants