Reverting setting HPA namespace variable #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nils Bergmüller <[email protected]>
JorTurFer
approved these changes
Nov 7, 2024
wozniakjan
pushed a commit
to wozniakjan/keda-charts
that referenced
this pull request
Nov 28, 2024
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly both metrics-server and HPA namespaces were updated in the previous MR where I added an option to use custom metrics-server namespace, this should be partially reverted since it should be required only for RoleBinding of metrics-server, not ClusterRoleBinding of HPA.
Checklist
Fixes #