Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pause autoscaling #840

Closed
jchobantonov-runbuggy opened this issue Nov 17, 2023 · 2 comments · Fixed by #899
Closed

add pause autoscaling #840

jchobantonov-runbuggy opened this issue Nov 17, 2023 · 2 comments · Fixed by #899

Comments

@jchobantonov-runbuggy
Copy link

Proposal

ScaledObject have ability to pause autoscaling in events where manual scaling is needed. HTTPScaledObject do not support the annotations that ScaledObject provides which are defined in ScaledObject yaml:

metadata:
  annotations:
    autoscaling.keda.sh/paused-replicas: "0"                # Optional. Use to pause autoscaling of objects
    autoscaling.keda.sh/paused: "true"                      # Optional. Use to pause autoscaling of objects explicitly

Use-Case

If for some reason autoscaling do not behave as it should be (like external monitoring values are not right which could cause strange behavior etc) to have ability to temporary pause the autoscaling.

Is this a feature you are interested in implementing yourself?

No

Anything else?

No response

@jchobantonov-runbuggy
Copy link
Author

or a better way could be to supply with a template section in HTTPScaledObject as to how the dynamic ScaledObject should be created this providing ability to control the dynamically created ScaledObject and provide not only pause autoscaling but also ability to add additional triggers

@JorTurFer
Copy link
Member

or a better way could be to supply with a template section in HTTPScaledObject as to how the dynamic ScaledObject should be created this providing ability to control the dynamically created ScaledObject and provide not only pause autoscaling but also ability to add additional triggers

This is something in progress as part of this PR: #795
It's not exactly the same, but it allows generating your own ScaledObject totally detached from the HTTPScaledObject and totally under your control. This brings you the option of adding ScaledObject with HTTP triggers and other triggers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants