Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Kedge JSON Schema generation configurable #22

Open
concaf opened this issue Dec 27, 2017 · 2 comments
Open

Make Kedge JSON Schema generation configurable #22

concaf opened this issue Dec 27, 2017 · 2 comments

Comments

@concaf
Copy link
Contributor

concaf commented Dec 27, 2017

Currently, when we run openapi2jsonschema like openapi2jsonschema _output/kedge-oapi.json -o schema/ --stand-alone, all the objects are generated which we do not need a lot of times.

We need to configure this such that we get the flexibility to generate only controllers.

@surajssd attempted to solve this here - surajssd/openapi2jsonschema@766a276

But we need to filter out controllers before passing on to openapi2jsonschema using tools like jq or something similar.
@concaf concaf changed the title Make Kedge JSON Schema configurable Make Kedge JSON Schema generation configurable Dec 27, 2017
@kadel kadel mentioned this issue Jan 2, 2018
Closed
@concaf concaf self-assigned this Jan 3, 2018
concaf added a commit to concaf/json-schema-generator that referenced this issue Jan 3, 2018
@concaf
Output only controller specific JSON Schema
634a830 
This commit makes schemagen output only JSON Schema for the
Kedge controllers by default. This behavior can be changed by
setting --controller flag to false.

Fixes kedgeproject#22
@concaf concaf mentioned this issue Jan 3, 2018
Merged
@concaf concaf closed this as completed in #27 Jan 3, 2018
@concaf concaf reopened this Jan 3, 2018
@concaf
Copy link
Contributor Author

concaf commented Jan 4, 2018

Tried this with #27 but then the JSON Schema being outputted was invalid.
For now, I've copied the controllers specific schema files to a new controllers/ directory which should help in making the structure better. I also don't see any harm in this because it's nice to have all the files and then the controller specific files anyway, so we see what's going on under the hood.

@kadel
Copy link
Member

kadel commented Jan 15, 2018

It is really confusing to have all those unnecessary files :-(

@concaf concaf removed their assignment May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kadel @concaf