Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong version of pinned dependency Kedro in Kedro-Datasets #436

Closed
javihernaxpo opened this issue Nov 20, 2023 · 3 comments
Closed

Wrong version of pinned dependency Kedro in Kedro-Datasets #436

javihernaxpo opened this issue Nov 20, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@javihernaxpo
Copy link

javihernaxpo commented Nov 20, 2023

Description

The version of Kedro in dependencies is not correct to use Kedro-Datasets.

Context

The version specified is Kedro>=0.16. Testing with kedro version 0.17.7 and python 3.8, I get the following error when trying to import the pandas.ParquetDataset:

from kedro_datasets.pandas.parquet_dataset import ParquetDataset
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/jovyan/my-conda-envs/fact/lib/python3.8/site-packages/kedro_datasets/pandas/parquet_dataset.py", line 26, in <module>
    class ParquetDataset(AbstractVersionedDataset[pd.DataFrame, pd.DataFrame]):
TypeError: 'ABCMeta' object is not subscriptable

It should be pinned to Kedro >=0.18.2

Steps to Reproduce

  1. python version 3.8
  2. kedro version 0.17.7
  3. from kedro_datasets.pandas.parquet_dataset import ParquetDataset

Expected Result

It corrects imports the class

Actual Result

Fails with error:
TypeError: 'ABCMeta' object is not subscriptable

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/jovyan/my-conda-envs/fact/lib/python3.8/site-packages/kedro_datasets/pandas/parquet_dataset.py", line 26, in <module>
    class ParquetDataset(AbstractVersionedDataset[pd.DataFrame, pd.DataFrame]):
TypeError: 'ABCMeta' object is not subscriptable```

-- Separate them if you have more than one.


## Your Environment
Include as many relevant details about the environment in which you experienced the bug:

* Kedro version used (`pip show kedro` or `kedro -V`): 0.17.7
* Kedro plugin and kedro plugin version used (`pip show kedro-airflow`): kedro-datasets=1.8.0
* Python version used (`python -V`): Python 3.8.17 
* Operating system and version: Ubuntu 20.04.4 LTS
@javihernaxpo javihernaxpo changed the title <Title> Wrong version of pinned dependency Kedro in Kedro-Datasets Nov 20, 2023
@astrojuanlu
Copy link
Member

Thanks @javihernaxpo for reporting, you're right:

dependencies = [
"kedro>=0.16",

We should fix it. Would you like to send a pull request for it?

@astrojuanlu astrojuanlu added the bug Something isn't working label Nov 20, 2023
@astrojuanlu
Copy link
Member

After giving this a second look it's not so obvious what's going on here, we deliberately relaxed the pinning because it was problematic and we checked compatibility back then. We'll have to dig a bit more.

@merelcht
Copy link
Member

Thanks for flagging this @javihernaxpo, however we deliberately made the pinning less strict as it was causing lots of issues for users with older Kedro versions. See this conversation from kedro-org/kedro#2409 (comment). We will not change this approach to allow our users flexibility with their Kedro versions.

@merelcht merelcht closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants