Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataCatalog2.0]: Move config validation to the CatalogConfigResolver init #4188

Closed
ElenaKhaustova opened this issue Sep 24, 2024 · 2 comments
Assignees
Labels
Issue: Feature Request New feature or improvement to existing feature

Comments

@ElenaKhaustova
Copy link
Contributor

Description

Currently, we resolve dataset configuration for patterns at the runtime. During the resolution, we validate the config format and raise the error in case of failure:

def _resolve_dataset_config(

We suggest moving the config validation step to the CatalogConfigResolver init so that we do not allow creating a config resolver object with incorrect pattern configurations.

Context

#4151 (comment)

Possible Implementation

  1. Move config validation step to the CatalogConfigResolver's constructor and raise an error in case an incorrect configuration is provided
  2. Simplify CatalogConfigResolver._resolve_dataset_config method keeping only filling placeholders logic

Possible Alternatives

@merelcht
Copy link
Member

Is there anything more to do here or is this ticket fully resolved by #4195? @ElenaKhaustova

@ElenaKhaustova
Copy link
Contributor Author

@merelcht It's done, closing now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Feature Request New feature or improvement to existing feature
Projects
Status: Done
Development

No branches or pull requests

2 participants