Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add official support for Python 3.13 #4267

Closed
3 of 9 tasks
astrojuanlu opened this issue Oct 29, 2024 · 9 comments
Closed
3 of 9 tasks

Add official support for Python 3.13 #4267

astrojuanlu opened this issue Oct 29, 2024 · 9 comments
Assignees

Comments

@astrojuanlu
Copy link
Member

astrojuanlu commented Oct 29, 2024

Description

Just tested the Spaceflights starter on Python 3.13 and everything works smoothly.

See #3587 for the addition of official Python 3.12 support.

@astrojuanlu
Copy link
Member Author

astrojuanlu commented Nov 4, 2024

This will be the parent issue tracking all repos. The upgrade most likely needs to happen in a certain order.

  • kedro-org/kedro
  • kedro-org/kedro-starters
  • kedro-org/kedro-plugins
  • kedro-org/kedro-viz
  • kedro-org/vscode-kedro

@noklam
Copy link
Contributor

noklam commented Nov 7, 2024

https://github.com/kedro-org/kedro/actions/runs/11666306391/job/32480967172?pr=4276

Adding some info here, seems like it breaks some micropkg command in 3.13 Windows

@ravi-kumar-pilla
Copy link
Contributor

Hi Team,

There are some blockers adding python 3.13 support for kedro-plugins

  1. Kedro-airflow - blocked by apache-airflow support for python 3.13
    ERROR: ERROR: Failed to build installable wheels for some pyproject.toml based projects (google-re2, msgspec)
    Related issues as I could not find any active discussion in apache-airflow for python 3.13 -
    Google re2 : Open issues - Python 3.13 google/re2#516
    Msgspec : New release for Python 3.13 jcrist/msgspec#764

  2. Kedro-datasets - blocked by tensorflow

    Tensorflow - It doesn't support on python3.13 tensorflow/tensorflow#78774

Thank you

@noklam
Copy link
Contributor

noklam commented Nov 18, 2024

Just to clarify, we can still do a release for kedro and kedro-datasets without python 3.13 support right? We break kedro-datasets exactly for this reason so I don't see that as a blocking factor.

@ravi-kumar-pilla
Copy link
Contributor

Just to clarify, we can still do a release for kedro and kedro-datasets without python 3.13 support right? We break kedro-datasets exactly for this reason so I don't see that as a blocking factor.

I did not fully understand what you meant by a release without python 3.13 support. So python 3.13 support is merged in Kedro but for kedro-datasets the build is failing as Tensorflow does not yet support python 3.13 and our build depends on that.

@ravi-kumar-pilla
Copy link
Contributor

Hi Team,

Blockers for python 3.13 support on -

Kedro-plugins:

Kedro-starters: The PR is merged but waiting for 3.13.1 patch release

Thank you

@merelcht
Copy link
Member

Re kedro-starters: this is just for adding 3.13 builds to the starters, but doesn't make any changes in the code, so we're still good on releasing kedro with 3.13 support. It's also fine to wait with kedro-airflow and kedro-datasets. I suggest creating separate tickets for all of these so we can track them and the blockers individually.

@ravi-kumar-pilla
Copy link
Contributor

Closing this in favor of - kedro-org/kedro-plugins#940 and kedro-org/kedro-starters#259

@github-project-automation github-project-automation bot moved this from In Progress to Done in Kedro Framework Nov 21, 2024
@noklam
Copy link
Contributor

noklam commented Nov 28, 2024

@ravi-kumar-pilla What I mean the dataset release should not be blocked by one dataset. We can temporarily skip that specific dataset for 3.13 until they release a compatible version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants