Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update names of modules for tbtc-mg, tbtc-v2.ts and cross-chain/arbitrum #40

Open
michalinacienciala opened this issue Mar 13, 2023 · 0 comments
Open

Update names of modules for tbtc-mg, tbtc-v2.ts and cross-chain/arbitrum #40

michalinacienciala opened this issue Mar 13, 2023 · 0 comments
Assignees
@dimpar

Comments

@michalinacienciala
Copy link
Collaborator

michalinacienciala commented Mar 13, 2023 •
edited
Loading

The first three chunks of the module name in ./config/config.json need to represent the repository name. So we have to start with github.com/keep-network/tbtc-v2 when naming module for cross chain arbitrum module. I propose either github.com/keep-network/tbtc-v2/arbitrum or github.com/keep-network/tbtc-v2/cross-chain-arbitrum.

In the same PR we could change the name of github.com/keep-network/tbtc-mg module to github.com/keep-network/optimistic-minting and github.com/keep-network/tbtc-v2.ts to github.com/keep-network/tbtc-v2/typescript (as they're incorrectly named as well).
@michalinacienciala michalinacienciala mentioned this issue Mar 13, 2023
Merged
@dimpar dimpar mentioned this issue Mar 14, 2023
Merged
@michalinacienciala michalinacienciala changed the title Update names of modules for tbtc-mg and cross-chain/arbitrum Update names of modules for tbtc-mg, tbtc-v2.ts and cross-chain/arbitrum Mar 14, 2023
michalinacienciala added a commit that referenced this issue Mar 27, 2023
@michalinacienciala
Merge pull request #41 from keep-network/arbitrum
5b00aab 
Changing arbitrum module name

Refs #40

This PR is a followup up PR to this comment keep-network/tbtc-v2#554 (comment) around naming CI modules.

first three chunks of the module name need to represent the repository name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimpar dimpar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dimpar @michalinacienciala