Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Improve tests of router contract. #492

Open
sparqet opened this issue Oct 4, 2023 · 8 comments
Open

test: Improve tests of router contract. #492

sparqet opened this issue Oct 4, 2023 · 8 comments
Labels
enhancement New feature or request testing

Comments

@sparqet
Copy link
Collaborator

sparqet commented Oct 4, 2023

Description

Implement and improve tests of router contract.

File: test/router/router.cairo.

Acceptance criteria

  • Unit tests (nominal and failure) are implemented and passing.
@sparqet sparqet added enhancement New feature or request testing labels Oct 4, 2023
@Ephraim-nonso
Copy link

Hi, @sparqet . I will love to work on this.

@sparqet
Copy link
Collaborator Author

sparqet commented Oct 5, 2023

Sure !

@Ephraim-nonso
Copy link

Hi @sparqet

Does this include adding a test for the exchange_router file as well? or strictly add more test to the router file.

@sparqet
Copy link
Collaborator Author

sparqet commented Oct 18, 2023

Hi ! Just add for router file, there will be another issue for exhange_router

@Ephraim-nonso
Copy link

Alright.

@henryjindal112
Copy link

Hey @sparqet, I would like to work on it

@Oshioke-Salaki
Copy link

Please i would love to be assigned this

@onlydustapp OnlyDustApp
Copy link

onlydustapp bot commented Aug 2, 2024

Hey @adrianvrj!
Thanks for showing interest.
We've created an application for you to contribute to Satoru.
Go check it out on OnlyDust!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sparqet @Ephraim-nonso @Oshioke-Salaki @henryjindal112