-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passkey support doesn't provide getAuthenticatorData for WebAuthn #2061
Comments
We currently don't support any attestation with the Passkey feature. |
Is there some formal description of what parts of the spec (and which spec then) are supported by this plugin? Like, for example, does it support the webauthn spec at all, and on what level? |
See keepassxreboot/keepassxc#8825 for the current support. |
Could it be better to respond with "None"-attestation format for forward compatibility? There was a problem where the server assumed only the latest level of the spec from the client and was looking for attestation in the response. |
@varjolintu {
"attestationObject": "o2NmbXRkbm9uZWdhdHRTdG10oGhhdXRoRGF0YVkBZ8g1D_AzJTBVGNHi09dMVmpPEGId9Nb25ACq-N1pt3GvRQAAAAD9sUGyXYREPoo1RpjCBaUCACCRhZd9KtFBTPoFmf84gjsknzJQid7HJypxH7NYDDX1M6QBAwM5AQAgWQEAvOOYcaDBS4DRyjgWTUJzJWY_drlY-Fafi3iatAqy1kxKixVWMn5sFWDoxm23Fh2UpC6M6ZbEztLCC7b2wNJkiJ_pfAofIoj1yhxjEKvInhmZO47oqeJgWHgZIwFD_6d4PN9Q0DF770muJybO3M5hXoIMlpPakUsHg7xU-RyPdzhANKjOI_3l4u-1hI7BYWtg7xU-3jJ2jrFK8wxhUtwOjAeZd33cVSSoL-JvJOg6pn0a3XTBvPwrSh-nqnjkVBeePJ_XuFs9dExbX4UDTK0yYG6hWNNLaR8koYtZa22SVqiALA4gFBz6ar10TyTOei1VuPGc8vqGF0AO5eTHDzwCDSFDAQAB",
"clientDataJSON": "eyJjaGFsbGVuZ2UiOiJHTG9rNUJYNTVfZ0xxVUF5S09yVkMza1lpVEw3WWJia0I4Sm9TMkVvWTh3IiwiY3Jvc3NPcmlnaW4iOmZhbHNlLCJvcmlnaW4iOiJodHRwczovL3dlYmF1dGhuLmRvZG8uZGV2IiwidHlwZSI6IndlYmF1dGhuLmNyZWF0ZSJ9",
"clientExtensionResults": {}
} There is no Therefore, issue is still present in the current version of KeePassXC (2.7.8). |
@vanbukin Thanks for letting me know. I'll check it out. |
@vanbukin There's another bug in the page. It also checks for EDIT: I got the site working. |
This is now fixed for KeePassXC 2.7.9. |
Expected Behavior
I am trying to authenticate using Passkey on a test site of WebAuthn.NET library (sources are here), and it doesn't work: the library throws an exception when trying to access
response.getAuthenticatorData
function on the received object.Current Behavior
The following snippet throws an error, because there's no
getAuthenticatorData
function:(
newCredential.response
here is meant to be anAuthenticatorAttestationResponse
, here's a link to the spec)Link to the corresponding JS sources.
Possible Solution
keepasssc-browser should implement a corresponding part of the spec and provide all the methods required by the spec on its
response
object somehow.Steps to Reproduce (for bugs)
(Copied from my report at dodobrands/WebAuthn.Net#1)
Debug info
KeePassXC-Browser Version: 1.8.10
Operating system: Win
Browser: Chrome 120.0.6099.130
The text was updated successfully, but these errors were encountered: