Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When changing password from within browser, password is not saved in KDBX file #2088

Closed
Bart80-1 opened this issue Jan 20, 2024 · 3 comments
Closed

Comments

@Bart80-1
Copy link

Expected Behavior

I found this out while changing my password on Github. But possibly it is the same problem on other pages.

When I change my password via the appropriate page on Github, Keepassxc-browser correctly finds out that the password is changed and shows the dialog where it mentions that username or password has changed with the options to either create a new entry or to update the existing one. When clicking the option to update the existing entry, I would expect that the password is changed in the existing entry.

Current Behavior

When clicking the option to update the existing entry, nothing happens - the banner is not removed and the entry is not saved. Also, no new entry is created in the KDBX file.

Possible Solution

Steps to Reproduce (for bugs)

  1. Visit https://github.com/settings/security
  2. Update your password. I used the password generated (in case this is relevant)
  3. Save the password using the Update password button
  4. A banner appears displaying the message (translated myself from Dutch, so possibly not literally the message) "Username of password changed! Save?" with the buttons "New", "Update" and "Ignore".
  5. When clicking Update, nothing happens - banner remains and no entries are added or updated in the KDBX file.

Debug info

KeePassXC - 2.7.6
KeePassXC-Browser - 1.8.11
Operating system: Linux x86_64
Browser: Mozilla Firefox 121.0

@varjolintu
Copy link
Member

This is already fixed in the KeePassXC side. Wait for the new release.

@varjolintu varjolintu closed this as not planned Won't fix, can't repro, duplicate, stale Jan 20, 2024
@Bart80-1
Copy link
Author

This is already fixed in the KeePassXC side. Wait for the new release.

Ok thanks.
Just for my info, what issue is this exactly linked to on KeepassXC side? Cannot immediately find something that fits in...

@varjolintu
Copy link
Member

@Bart80-1 keepassxreboot/keepassxc#9853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants