Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to move forward #19

Open
prashantsengar opened this issue Oct 12, 2020 · 0 comments
Open

How to move forward #19

prashantsengar opened this issue Oct 12, 2020 · 0 comments

Comments

@prashantsengar
Copy link
Member

So we are starting again after a long time

In my last PR, I attempted to fix a few bugs PR#17

Rewriting them here:

Added deletion counter to fix issue #9
Added image for empty state to fix issue #6
Added preview for text files to fix a few things in issue #1

The updates regarding them

1. Deletion counter

I added it but due to Tkinter's GUI features, there are only two ways to do that

Image 1
Image 2

I could not find a way to do the Twitter like UI because:

  • There can be only one text on the Sweep button
  • Text cannot be kept partially bold and "un-bold" in Tkinter.

We need to find a way to do this

2. Image for empty state

We need to do what we did in Twitter, we will have to generate a new image each time there is an empty state. Can use Pillow for that.

[ ] Need to get the template image, if possible. Otherwise, create one

3. Text file thumbnail works, if there is anything to be changed, I can do that otherwise I will create a new PR just for that and then we can merge it.

All the screenshots for above 3 points can be seen in #17

4. Thumbnail for PDF files

I tried to add this for my personal use when I had a lot of PDF files to be removed. I am using Windows so it was a bit hacky, had to install a lot of things. I am not sure how to go about this. Can we discuss about this?

@prashantsengar prashantsengar pinned this issue Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant