Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused (if they really are unused) resources #291

Open
chalkos opened this issue May 24, 2017 · 0 comments
Open

Remove unused (if they really are unused) resources #291

chalkos opened this issue May 24, 2017 · 0 comments
Milestone

Comments

@chalkos
Copy link
Contributor

chalkos commented May 24, 2017

There are some resource files that don't seem to have any use. These files are related to internationalization files, but do not specify the language.

Examples:

  • src/main/resources/properties/help.properties
  • src/main/resources/properties/lang.properties
  • src/main/resources/help/help.html

There are other files with similar names that also include a language code (_en, _pt, _hu, etc).

It would make sense that these are the default files that are used when the locale can not be determined, although there are some inconsistencies like src/main/resources/properties/lang.properties being in english and src/main/resources/help/help.html being in portuguese.

Maybe it would be best to assume the default language to be english?
Or ask the user for a preferred language when one could not be determined automatically?

@luis100 luis100 added this to the Unplanned milestone Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants