Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability to reap EC2 nodes not managed by ASG #72

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tasktop-teho
Copy link

closes #70

@tasktop-teho tasktop-teho requested a review from a team as a code owner October 29, 2022 01:41
@shrinandj
Copy link
Collaborator

Can you share some details of the testing done for this PR? Would governor now work for both ASGs and non-ASGs? If a cluster has a mix of some nodes in an ASG and some that aren't, would governor correctly terminate the appropriate instance?

@tasktop-teho
Copy link
Author

Our cluster has a mix of ASG and non-ASG managed nodes, and my change was able to reap both. I am trying to understand the tests in this repo, and will try to add tests for my changes.

Thanks @shrinandj

@tasktop-teho tasktop-teho marked this pull request as draft November 1, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to node reap non-ASG nodes
2 participants