Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we delete service account as part of cluster unregistration? #12

Open
mnkg561 opened this issue Mar 24, 2020 · 0 comments
Open
Labels
cluster controller question Further information is requested

Comments

@mnkg561
Copy link
Contributor

mnkg561 commented Mar 24, 2020

Is this a BUG REPORT or FEATURE REQUEST?:
QUESTION

What happened:
When admin wants to unregister any cluster with manager, should we

  1. Delete the service account in the target cluster?

There could be couple of things happened during registration

  1. User provided service account name directly
  2. User allowed manager cli to create service account.

In the 2nd option, probably it is okay to delete the service account but in 1st option, may be we shouldn't?

Apart from that, If we want to delete all the RBAC resources (sa, cluster-role, cluster role-binding) which is installed during registration, it gets into very interesting as if you delete the cluster-role-binding first you lose the access to delete anything with that service account as there is no binding so either way you are gonna have some orphan resources and probably user have to clean it up by themselves.

What you expected to happen:
Unregistration needs to be properly documented with the steps

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • manager version
  • Kubernetes version :
$ kubectl version -o yaml

Other debugging information (if applicable):

- controller logs:

$ kubectl logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cluster controller question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant