Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Upgrade-Manager V2 and v1alpha2 #127

Open
eytan-avisror opened this issue Nov 3, 2020 · 1 comment
Open

Epic: Upgrade-Manager V2 and v1alpha2 #127

eytan-avisror opened this issue Nov 3, 2020 · 1 comment
Labels
enhancement New feature or request P0

Comments

@eytan-avisror
Copy link
Contributor

eytan-avisror commented Nov 3, 2020

We would like to re-write the upgrade-manager controller in order to take better advantage of controller-runtime reconciler and handling of state changes.

Currently the controller creates a goroutine to process the rotation when the CR is created and exits once the operation is complete - and does not continually reconcile the custom resource. - This is causing a lot of issues around stale state - e.g. If an ASG instance state has changed, we never know about it.

If we constantly reconcile the CR by checking the state, moving rotation forward, and requeuing the CR - we would have much more accurate state with potentially more efficient API calls.

Suggestion is to re-write the controller, and utilize existing code as much as possible and implement the same API used in v1alpha1.

As a second step, we should consider adding v1alpha2 with API improvements.

@eytan-avisror eytan-avisror added enhancement New feature or request P0 labels Nov 3, 2020
@eytan-avisror
Copy link
Contributor Author

@uthark FYI
We are starting this work on branch controller-v2, we will add you as reviewer before we merge (currently we just got started).
High level goals are refactoring code for maintainability, better package structure, and better state handling / reconcile / caching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P0
Projects
None yet
Development

No branches or pull requests

1 participant