Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default deployment should not use cluster-admin role #299

Open
preflightsiren opened this issue Aug 16, 2021 · 0 comments
Open

Default deployment should not use cluster-admin role #299

preflightsiren opened this issue Aug 16, 2021 · 0 comments

Comments

@preflightsiren
Copy link

Is this a BUG REPORT or FEATURE REQUEST?: both?

What happened: In the main readme, the installation docs reference https://raw.githubusercontent.com/keikoproj/upgrade-manager/master/deploy/rolling-upgrade-controller-deploy.yaml
This creates a service account rolling-upgrade-sa that is assigned the cluster-admin ClusterRole

What you expected to happen: either reference https://github.com/keikoproj/upgrade-manager/blob/master/config/rbac/role.yaml or less privileged cluster role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@preflightsiren