From 4615eb2acf9c718f2b3ba52611436a874ca6e9ab Mon Sep 17 00:00:00 2001 From: Kelly Selden <602423+kellyselden@users.noreply.github.com> Date: Sun, 17 Nov 2024 18:45:26 -0800 Subject: [PATCH 1/2] add windows ci since we are doing file system linting --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 37b0051..114de5a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -28,6 +28,7 @@ jobs: matrix: os: - ubuntu-latest + - windows-latest node: - 18 From 46f1916832f2c1b3e589a3a4b638304f7067772c Mon Sep 17 00:00:00 2001 From: Kelly Selden <602423+kellyselden@users.noreply.github.com> Date: Sun, 17 Nov 2024 18:49:02 -0800 Subject: [PATCH 2/2] use path.posix fast-glob isn't handling windows paths --- lib/rules/ensure-workspaces.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/rules/ensure-workspaces.js b/lib/rules/ensure-workspaces.js index 7188e84..1f025ed 100644 --- a/lib/rules/ensure-workspaces.js +++ b/lib/rules/ensure-workspaces.js @@ -49,7 +49,10 @@ module.exports = { continue; } - let glob = path.join(node.value, 'package.json'); + // fast-glob isn't handling windows paths + let _path = path.posix; + + let glob = _path.join(node.value, 'package.json'); let entries = fg.sync(glob, { cwd: path.dirname(filename)