Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unresponsive after playing a MIDI file without lyrics #10

Open
kelvinlawson opened this issue Nov 15, 2011 · 0 comments
Open

Unresponsive after playing a MIDI file without lyrics #10

kelvinlawson opened this issue Nov 15, 2011 · 0 comments

Comments

@kelvinlawson
Copy link
Owner

Reported on mailing list by Pietro Battiston:

there are some MIDI files (I can provide an example only privately,
since they are not free) for which, when played, PyKaraoke only shows
the error
"ERROR: Could not parse the MIDI file"
and then, in another MessageDialog, the error
"No lyrics in the track".
Now, that would be fair to me... the only problem is that then,
pykaraoke is stuck: not unresponsive, but it won't play any other file,
and will print forever in the terminal:
Traceback (most recent call last):
File "/usr/lib/pymodules/python2.7/pykaraoke.py", line 3815, in
handleIdle
position = self.Player.GetPos()
File "/usr/lib/pymodules/python2.7/pykar.py", line 1072, in GetPos
if self.useMidiTimer:
AttributeError: midPlayer instance has no attribute 'useMidiTimer'

Interestingly, if I played some MIDI before trying to play the faulty
one, then in the background that will play again, but without showing
the lyrics (and i will not be able to stop it in any way).

You may think it is stupid to play faulty MIDI files, or MIDI files
without lyrics... but when I have a huge library it's impossible to try
all of them before, and then it's also annoying to have to restart the
program (and loose the queue) any time a faulty one is chosen...

Maybe an alternative fix could be to (optionally) run some "validity
check" on MIDI files when refreshing the library?

by the way, thanks for the nice app

Pietro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant