From 0b90eafdac0c9e2cf2177503b87e4ac714dc80e0 Mon Sep 17 00:00:00 2001
From: Luke Stanley <luke.stanley@gmail.com>
Date: Tue, 26 Nov 2024 17:03:30 +0000
Subject: [PATCH] Ensures MatFormField label is always present

---
 cypress/e2e/spec.ts                                            | 2 +-
 .../block-builder-box/block-builder-box.component.html         | 3 ++-
 .../block-mapping-builder-box.component.html                   | 3 ++-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/cypress/e2e/spec.ts b/cypress/e2e/spec.ts
index 34e39f121..7b90ea3e6 100644
--- a/cypress/e2e/spec.ts
+++ b/cypress/e2e/spec.ts
@@ -72,7 +72,7 @@ describe('workspace-project App', () => {
     cy.get('[data-cy="toolbar-setting-button"]').click();
     cy.get('app-workflow-sidenav').contains('testingComment').should('exist');
     cy.get('app-workflow-sidenav').contains('testingComment').click();  
-    // cy.get('app-workflow-sidenav').contains('Block Comment'); // FIXME: regression - MatFormField placeholder text is not visible
+    cy.get('app-workflow-sidenav').contains('Block Comment');
   });
 
 
diff --git a/src/app/components/block-builder-box/block-builder-box.component.html b/src/app/components/block-builder-box/block-builder-box.component.html
index ad96a6b03..0930aaaf2 100644
--- a/src/app/components/block-builder-box/block-builder-box.component.html
+++ b/src/app/components/block-builder-box/block-builder-box.component.html
@@ -6,6 +6,7 @@
 </ng-container>
 
 <mat-form-field class="block-comment-container">
-  <textarea type="textarea" rows="2" placeholder="Block Comment" aria-label="Block Comment" matInput
+  <mat-label>Block Comment</mat-label>
+  <textarea type="textarea" rows="2" aria-label="Block Comment" matInput
     [formControl]="blockCommentFormControl" ></textarea>
 </mat-form-field>
diff --git a/src/app/components/block-mapping-builder-box/block-mapping-builder-box.component.html b/src/app/components/block-mapping-builder-box/block-mapping-builder-box.component.html
index fea4ff85a..a4a1e4ea0 100644
--- a/src/app/components/block-mapping-builder-box/block-mapping-builder-box.component.html
+++ b/src/app/components/block-mapping-builder-box/block-mapping-builder-box.component.html
@@ -1,5 +1,6 @@
 <ngx-monaco-editor [options]="editorOptions" style="height: 240px;" [(ngModel)]="mappingModel"></ngx-monaco-editor>
 <mat-form-field class="block-comment-container">
-  <textarea type="textarea" rows="3" placeholder="Block Comment" aria-label="Block Comment" matInput
+  <mat-label>Block Comment</mat-label>
+  <textarea type="textarea" rows="3" aria-label="Block Comment" matInput
     [formControl]="blockCommentFormControl" ></textarea>
 </mat-form-field>