Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting song request rate limit to zero will permanently deny client #248

Open
kenellorando opened this issue Mar 27, 2023 · 0 comments
Open
Labels
domain: cadence-api Relates to cadence API domain: cadence-db Relates to cadence database type: bug

Comments

@kenellorando
Copy link
Owner

kenellorando commented Mar 27, 2023

Setting the request rate limit to 0 will actually keep the client's IP in the rate limit database with no expiration, forever keeping it from ever making a request again after the first one is made. (at least until the database server is restarted)

0 used to be used as the number of seconds a client would be denied after they make a request, but ever since since the transition to Redis, we've been using this number as a value for "key expiration". In Redis, if this this value is set to 0, it is actually setting the key to never expire.

Expected behavior should see setting 0 to mean "no rate limiting".

@kenellorando kenellorando added type: bug domain: cadence-api Relates to cadence API domain: cadence-db Relates to cadence database labels Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: cadence-api Relates to cadence API domain: cadence-db Relates to cadence database type: bug
Projects
None yet
Development

No branches or pull requests

1 participant