Skip to content
This repository has been archived by the owner on Nov 3, 2022. It is now read-only.

bug in CRF method 'add_boundary_energy'? #539

Open
vandeb69 opened this issue Apr 29, 2020 · 1 comment
Open

bug in CRF method 'add_boundary_energy'? #539

vandeb69 opened this issue Apr 29, 2020 · 1 comment

Comments

@vandeb69
Copy link

Dear,
In the CRF class method add_boundary_energy, shouldn't

end_mask = K.cast(K.greater(self.shift_left(mask), mask), K.floatx())
be replaced with: end_mask = K.cast(K.greater(mask, self.shift_left(mask)), K.floatx()) ?

If mask is [[0., 1., 1., 1., 1., 0.]], end_mask would be [[1., 0., 0., 0., 0., 0.]] in stead of the intended [[0., 0., 0., 0., 1., 0.]]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants