Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning is better than ValueError : SD [MAX_PROMPT_LENGTH] #1085

Closed
innat opened this issue Dec 3, 2022 · 3 comments
Closed

Warning is better than ValueError : SD [MAX_PROMPT_LENGTH] #1085

innat opened this issue Dec 3, 2022 · 3 comments

Comments

@innat
Copy link
Contributor

innat commented Dec 3, 2022

Instead of throwing value error, wouldn't it better to log warning message and truncate prompt as needed?

image
@LukeWood
Copy link
Contributor

LukeWood commented Dec 6, 2022

Silent errors are a lot worse than explicit errors. This is why we require value_range, don't have defaults for bounding box format, etc.

@LukeWood LukeWood closed this as completed Dec 6, 2022
@innat
Copy link
Contributor Author

innat commented Dec 6, 2022

Silent errors are a lot worse than explicit errors.

Agree. That's why warning message comes in. I wasn't suggesting silently auto-truncate. IMO, value eror is bit heavy here for the above if condition.

@innat
Copy link
Contributor Author

innat commented Mar 2, 2023 •
edited
Loading

@LukeWood Please, check this.

https://github.com/huggingface/diffusers/blob/91925fbb761d944d54271660c4c3cffee55798fa/examples/community/seed_resize_stable_diffusion.py#L201-L202

divamgupta/stable-diffusion-tensorflow#20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LukeWood @innat