Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese language alpha 2 misconifgured #150

Closed
ChielWH opened this issue Aug 24, 2022 · 3 comments
Closed

Japanese language alpha 2 misconifgured #150

ChielWH opened this issue Aug 24, 2022 · 3 comments

Comments

@ChielWH
Copy link

ChielWH commented Aug 24, 2022

Hi!

When trying to use Term look-up in Japanese, I get the following error:

Error encountered while requesting the server.
{ "message": "The language specified is not supported or not valid. " }

I think the source of this error is that jp is used for abbreviating Japanese in the supported languages for term look-up:

var supportedLanguages = ["en", "es", "it", "fr", "de", "ar", "zh", "jp", "ru", "pt", "fa"];

While in the rest of the application it is abbreviated with ja (also on wikipedia itself). A test supporting this is to do a text disambiguation and fill in both the abbreviations in the lang field; providing ja yields expected results, providing jp yields the same error as shown above. I've tested this both on https://cloud.science-miner.com/nerd/ and on a local deployment, results are the same.

Besides this issue, props on this amazing project! We are getting great value from it!

@kermitt2
Copy link
Owner

Hi @ChielWH !

Thank you very much for the issue and the explanations, and sorry for the misspelling in the front-end file.

This is corrected with ef92268

@kermitt2
Copy link
Owner

Screenshot from 2022-08-25 06-18-56

@ChielWH
Copy link
Author

ChielWH commented Aug 25, 2022

Great! Thanks for the quick response.

@ChielWH ChielWH closed this as completed Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants