-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a way to reduce the number of relatedness values stored for cache #78
Comments
Relatedness might disappear in version 0.0.4 for a LSTM-based architecture. |
the issue affect any batch process running for more than a day, a relatively simple cache implementation can be used via Guava https://github.com/google/guava/wiki/CachesExplained#caches |
Regarding this issue, the concept of cache is implemented in another branch called "cacheGuava". The implementation is done in a Relatedness class. |
Implemented in branch: https://github.com/kermitt2/entity-fishing/tree/cacheGuava Tests using entity-fishing-client-python (branch: multitasking) - if problems, use goFishing,
Tests to run (3 time per test):
|
After hammering the system for several hours, the cache containing the list of all calculated relatedness reach the heap memory limit, causing the GC to be triggered too often (high CPU).
We should find an efficient solution to invalidate older element in this cache in order to keep the memory footprint lower.
The text was updated successfully, but these errors were encountered: