-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A single trade wipes out all the cash #1092
Comments
I suspect the error is in the following lines of code, specifically your indexes: if self.macd[0] > 0 and self.macd[1] > 0 and crossover(self.ema_fast, self.ema_slow):
self.sell()
elif self.macd[0] < 0 and self.macd[1] < 0 and crossover(self.ema_slow, self.ema_fast):
self.buy(size=self.order_size, limit=None, stop=None) An index of |
Thanks for your reply. Initially I thought you were right, but then I've checked better: self.macd[0] and self.macd[1] refer to the first two values in the MACD indicator, the MACD line and the signal line. It's correct what I copied. Indeed, if I need the current candle I use self.data.Close[-1]. |
i believe thats still an index problem for example using your original code with index 0 and 1 i get (low # trades with and maybe too long of a trade): but when i use -1 and 0 i get this (more trades): like this:
|
late reply, but in: if self.macd[0] > 0 and self.macd[1] > 0 and crossover(self.ema_fast, self.ema_slow):
self.sell()
elif self.macd[0] < 0 and self.macd[1] < 0 and crossover(self.ema_slow, self.ema_fast):
self.buy(size=self.order_size, limit=None, stop=None) your size is not set for |
Strategy
It's a very simple, naive strategy based on MACD: it returns only one trade over a period of 6 months (BCH-USD).
Actual Behavior
The issue is that, even if the order size is 0.1 that single trade wipes out all my capital (10,000). Indeed, in the stats I see Return=-100%. How can a single trade return -100% with an order size of 0.1? Any idea why this happens?
Additional info
bokeh.__version__
: 3.3.0The text was updated successfully, but these errors were encountered: