Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider breaking out build/test summaries #290

Open
spbnick opened this issue Jan 31, 2022 · 7 comments · May be fixed by #320 or #310
Open

Consider breaking out build/test summaries #290

spbnick opened this issue Jan 31, 2022 · 7 comments · May be fixed by #320 or #310
Assignees
@mrbazzan
Labels
good first issue Good for newcomers

Comments

@spbnick
Copy link
Collaborator

spbnick commented Jan 31, 2022

At the beginning of each notification we have a summary of checkout/build/test status. E.g.:

OVERVIEW

        Builds: ❌ FAIL
         Tests: ❌ FAIL

Later in the message we break those down by status. E.g.:

BUILDS

    Status
                 ❌ 83  ✅ 1065

and

TESTS

    Status
        ❌ 23  ✅ 17  ⏩ 32  🚧❌ 1  🚧✅ 1  🚧⏩ 9

However, since we have so many failures, a lot of which are false positives, we should consider duplicating the breakout at the introductory overview as well. I.e.:

OVERVIEW

        Builds: ❌ 83  ✅ 1065
         Tests: ❌ 23  ✅ 17  ⏩ 32  🚧❌ 1  🚧✅ 1  🚧⏩ 9

This would let the readers get a feeling for the results faster.

Suggested by @broonie.
@spbnick spbnick added the good first issue Good for newcomers label Jan 31, 2022
@spbnick
Copy link
Collaborator Author

spbnick commented May 11, 2022

@mrbazzan, would you be interested in taking this one on?

@mrbazzan
Copy link
Contributor

Yes. I'll get right on it.

@mrbazzan mrbazzan linked a pull request May 19, 2022 that will close this issue
Draft
@mrbazzan mrbazzan linked a pull request Aug 22, 2022 that will close this issue
Open
@mrbazzan
Copy link
Contributor

Hi @spbnick,
I won't be working on this for a while as I have exams coming up

@spbnick
Copy link
Collaborator Author

spbnick commented Oct 31, 2022

No problem, Abdulwasiu! I'm still struggling with post-COVID symptoms and only have energy for pushing work on known issues/incidents for now. Sorry for being quiet. Good luck with the exams!

@mrbazzan
Copy link
Contributor

mrbazzan commented Dec 9, 2022

Hello Nick,

Good luck with the exams!

Thanks. It was quite an exam.

I'm still struggling with post-COVID symptoms

I hope you are all better now?

I started working on this issue again. I pushed an update to #320. Please check when you can

@spbnick
Copy link
Collaborator Author

spbnick commented Jan 3, 2023

Hi Abdulwasiu! Feeling generally better, but might be having less immunity against everything as a COVID consequence. Have been having all kinds of smaller colds this autumn/winter. Sorry for another slow response, the pre-Christmas period was tough (as usual), and then I was away for two weeks for the holidays. Back now and looking at your updated PR!

@mrbazzan
Copy link
Contributor

mrbazzan commented Jan 3, 2023

Hi Abdulwasiu! Feeling generally better, but might be having less immunity against everything as a COVID consequence. Have been having all kinds of smaller colds this autumn/winter.

Sorry about that :(. Perhaps the cold is because of the weather?

Back now and looking at your updated PR!

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrbazzan mrbazzan

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@spbnick @mrbazzan