Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mainline: stack frame size exceeds limit on allmodconfig #482

Closed
musamaanjum opened this issue Nov 1, 2024 · 1 comment · Fixed by kernelci/kernelci-pipeline#870
Closed

mainline: stack frame size exceeds limit on allmodconfig #482

musamaanjum opened this issue Nov 1, 2024 · 1 comment · Fixed by kernelci/kernelci-pipeline#870
Assignees
@musamaanjum

Comments

@musamaanjum
Copy link

The allmodconfig has been enabled recently and we have found a failed build with clang-17: https://staging.kernelci.org:9000/viewer?search=parent%3D67236768025e418acd1174cc

The logs show that build failed because of stack frame size exceeds limit 2 times.

fs/bcachefs/chardev.c:881:6: error: stack frame size (1080) exceeds limit (1024) in 'bch2_fs_ioctl' [-Werror,-Wframe-larger-than]
  881 | long bch2_fs_ioctl(struct bch_fs *c, unsigned cmd, void __user *arg)
      |      ^

drivers/net/ethernet/qlogic/qede/qede_main.c:313:6: error: stack frame size (1056) exceeds limit (1024) in 'qede_fill_by_demand_stats' [-Werror,-Wframe-larger-than]
  313 | void qede_fill_by_demand_stats(struct qede_dev *edev)
      |      ^

I've looked at allmodconfig file for this and found out that:

CONFIG_FRAME_WARN=1024

The stack frame size is quite a common warning. But as error on warning flag may be set, this warning is being treated as error. CONFIG_FRAME_WARN can be set [0 8192]. The current value is set to 1024 and errors are getting generated at 1080 and 1056. We can report this upstream and/or increase the FRAME_WARN in configurations.

cc: @crazoes @nuclearcat
@musamaanjum musamaanjum self-assigned this Nov 1, 2024
@musamaanjum musamaanjum converted this from a draft issue Nov 1, 2024
@musamaanjum
Copy link
Author

The same error is occurring again today.

musamaanjum added a commit to musamaanjum/kernelci-pipeline that referenced this issue Nov 5, 2024
@musamaanjum
config: pipeline: Update CONFIG_FRAME_WARN for arm
b1882d9 
CONFIG_FRAME_WARN is set to 1024 by default for arm. The allowed value
for this is 0 to 8192. Let's increase it to 2048 to avoid getting the
warning when stack size is more than default 1024. As all warnings are
being treated as errors, our allmodconfig build fails on arm.

Close: kernelci/kernelci-project#482

Signed-off-by: Muhammad Usama Anjum <[email protected]>
@musamaanjum musamaanjum mentioned this issue Nov 5, 2024
Merged
github-merge-queue bot pushed a commit to kernelci/kernelci-pipeline that referenced this issue Nov 6, 2024
@musamaanjum @nuclearcat
config: pipeline: Update CONFIG_FRAME_WARN for arm
ea3fb8a 
CONFIG_FRAME_WARN is set to 1024 by default for arm. The allowed value
for this is 0 to 8192. Let's increase it to 2048 to avoid getting the
warning when stack size is more than default 1024. As all warnings are
being treated as errors, our allmodconfig build fails on arm.

Close: kernelci/kernelci-project#482

Signed-off-by: Muhammad Usama Anjum <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in KernelCI results data evaluation Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@musamaanjum musamaanjum

Labels
None yet
Projects
KernelCI results data evaluation
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config: pipeline: Update CONFIG_FRAME_WARN for arm musamaanjum/kernelci-pipeline
1 participant
@musamaanjum