fix(queries): remove exception when fetchType is NONE

remove exception for NONE make STORE default for fetchType
kestra-io · Nov 28, 2024 · e9ac855 · e9ac855
1 parent 0b11d2a
commit e9ac855
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/plugin-jdbc/src/main/java/io/kestra/plugin/jdbc/AbstractJdbcBaseQuery.java b/plugin-jdbc/src/main/java/io/kestra/plugin/jdbc/AbstractJdbcBaseQuery.java
@@ -65,7 +65,7 @@ public abstract class AbstractJdbcBaseQuery extends Task implements JdbcQueryInt
 
     @NotNull
     @Builder.Default
-    protected FetchType fetchType = FetchType.NONE;
+    protected FetchType fetchType = FetchType.STORE;
 
     @Builder.Default
     protected Integer fetchSize = 10000;

diff --git a/plugin-jdbc/src/main/java/io/kestra/plugin/jdbc/AbstractJdbcQueries.java b/plugin-jdbc/src/main/java/io/kestra/plugin/jdbc/AbstractJdbcQueries.java
@@ -111,6 +111,7 @@ private long extractResultsFromResultSet(RunContext runContext, AbstractCellConv
                             .rows(maps)
                             .size(size);
                     }
+                    case NONE -> runContext.logger().info("fetchType is set to NONE, no output will be returned");
                     default -> throw new IllegalArgumentException("fetchType must be either FETCH, FETCH_ONE, STORE, or NONE");
                 }
                 totalSize += size;