Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery and AdswerveBigQuery uses a service account in the working directory #66

Open
loicmathieu opened this issue Jul 10, 2024 · 4 comments
Labels
area/plugin Plugin-related issue or feature request bug Something isn't working good first issue Great issue for new contributors

Comments

@loicmathieu
Copy link
Member

Expected Behavior

BigQuery and AdswerveBigQuery uses a service account in the working directory which may not e compatible with all task runner.
We need to find another away.

Actual Behaviour

See https://github.com/kestra-io/plugin-singer/blob/master/src/main/java/io/kestra/plugin/singer/targets/AdswerveBigQuery.java#L157 and https://github.com/kestra-io/plugin-singer/blob/master/src/main/java/io/kestra/plugin/singer/taps/BigQuery.java#L118

Steps To Reproduce

No response

Environment Information

  • Kestra Version:
  • Plugin version:
  • Operating System (OS / Docker / Kubernetes):
  • Java Version (If not docker):

Example flow

No response

@loicmathieu loicmathieu added the bug Something isn't working label Jul 10, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Jul 10, 2024
@anna-geller
Copy link
Member

@loicmathieu is this still relevant? asking as I think in the end you and Brian adjusted task runners to inject the full working directory

@Ben8t
Copy link
Member

Ben8t commented Sep 9, 2024

@loicmathieu @brian-mulier-p is it something we can close ?

@anna-geller anna-geller added the area/plugin Plugin-related issue or feature request label Sep 15, 2024
@tchiotludo tchiotludo added good first issue Great issue for new contributors and removed kind/good-first-issue labels Oct 1, 2024
@brian-mulier-p
Copy link
Member

I think the AbstractSinger should take its workingDirectory from the taskRunner for it to work properly.

@loicmathieu I'd suggest that the CommandsWrapper's workingDirectory is instead taken from the taskRunner (same for outputDirectory) and since AbstractSinger takes its wdir from CommandsWrapper it will work, WDYT ?

For @Ben8t @anna-geller I'm pretty sure that it's effectively an issue as-of now (maybe worth doing a test with SA and a taskRunner to check ?)

@loicmathieu
Copy link
Member Author

@brian-mulier-p I have no idea, this needs to be sorted out but we must have a single working directory and not two

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Plugin-related issue or feature request bug Something isn't working good first issue Great issue for new contributors
Projects
Status: Backlog
Development

No branches or pull requests

5 participants