Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Link Previews via Open Graph #576

Open
kevinclement opened this issue Jan 6, 2024 · 2 comments
Open

Support Link Previews via Open Graph #576

kevinclement opened this issue Jan 6, 2024 · 2 comments

Comments

@kevinclement
Copy link
Owner

When people add links to site in discord, discord will try to render a nice preview. For SA that isn't available so its just a lame login image.

image

I believe if we add open graph support to the page it should make this nicer. See https://ogp.me/.

@maxdekrieger
Copy link
Contributor

maxdekrieger commented Jan 7, 2024

Love this, I had no idea how this preview could be changed. Will it a problem that most all of the logic and rendering is happening client-side?

@d-ellis
Copy link

d-ellis commented Feb 14, 2024

Love this, I had no idea how this preview could be changed. Will it a problem that most all of the logic and rendering is happening client-side?

Shouldn't be a problem at all. I've got static webpages that are served just with HTML using GitHub Pages, and Open Graph works for them

Edit: actually it depends on what information you want in the cards. Basic information is fine, but dynamic information I think would need to be generated on a server. The information is pulled from the HTML, scripts aren't executed so the info can't be generated from scripts afaik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants