Skip to content

Commit fab2980

Browse files
committed
assumevalid: log every script validation state change
The `-assumevalid` option skips script verification for a specified block and all its ancestors during Initial Block Download. Many new users are surprised when this suddenly slows their node to a halt. This commit adds a log message to clearly indicate when this optimization ends and full validation begins (and vice versa). When using `-assumeutxo`, logging is suppressed for the active assumed-valid chainstate and for the background validation chainstate to avoid the confusing toggles. ------- > cmake -B build && cmake --build build && mkdir -p demo && build/bin/bitcoind -datadir=demo -stopatheight=500 | grep 'signature validation' ``` 2025-08-08T20:59:21Z Disabling signature validations at block #1 (00000000839a8e6886ab5951d76f411475428afc90947ee320161bbf18eb6048). 2025-08-08T20:59:21Z Enabling signature validations at block #100 (000000007bc154e0fa7ea32218a72fe2c1bb9f86cf8c9ebf9a715ed27fdb229a). 2025-08-08T20:59:21Z Disabling signature validations at block bitcoin#200 (000000008f1a7008320c16b8402b7f11e82951f44ca2663caf6860ab2eeef320). 2025-08-08T20:59:21Z Enabling signature validations at block bitcoin#300 (0000000062b69e4a2c3312a5782d7798b0711e9ebac065cd5d19f946439f8609). ```
1 parent f679bad commit fab2980

File tree

3 files changed

+13
-6
lines changed

3 files changed

+13
-6
lines changed

src/validation.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2580,6 +2580,11 @@ bool Chainstate::ConnectBlock(const CBlock& block, BlockValidationState& state,
25802580
Ticks<SecondsDouble>(m_chainman.time_forks),
25812581
Ticks<MillisecondsDouble>(m_chainman.time_forks) / m_chainman.num_blocks_total);
25822582

2583+
if (fScriptChecks != m_prev_script_checks_logged && GetRole() == ChainstateRole::NORMAL) {
2584+
LogInfo("%s signature validations at block #%d (%s).", fScriptChecks ? "Enabling" : "Disabling", pindex->nHeight, block_hash.ToString());
2585+
m_prev_script_checks_logged = fScriptChecks;
2586+
}
2587+
25832588
CBlockUndo blockundo;
25842589

25852590
// Precomputed transaction data pointers must not be invalidated

src/validation.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -550,6 +550,8 @@ class Chainstate
550550
//! Cached result of LookupBlockIndex(*m_from_snapshot_blockhash)
551551
mutable const CBlockIndex* m_cached_snapshot_base GUARDED_BY(::cs_main){nullptr};
552552

553+
std::atomic_bool m_prev_script_checks_logged{true};
554+
553555
public:
554556
//! Reference to a BlockManager instance which itself is shared across all
555557
//! Chainstate instances.

test/functional/feature_assumevalid.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -153,12 +153,12 @@ def run_test(self):
153153
p2p1 = self.nodes[1].add_p2p_connection(BaseNode())
154154
p2p1.send_header_for_blocks(self.blocks[0:2000])
155155
p2p1.send_header_for_blocks(self.blocks[2000:])
156-
157-
# Send all blocks to node1. All blocks will be accepted.
158-
for i in range(2202):
159-
p2p1.send_without_ping(msg_block(self.blocks[i]))
160-
# Syncing 2200 blocks can take a while on slow systems. Give it plenty of time to sync.
161-
p2p1.sync_with_ping(timeout=960)
156+
with self.nodes[1].assert_debug_log(expected_msgs=['Disabling signature validations at block #1', 'Enabling signature validations at block #103']):
157+
# Send all blocks to node1. All blocks will be accepted.
158+
for i in range(2202):
159+
p2p1.send_without_ping(msg_block(self.blocks[i]))
160+
# Syncing 2200 blocks can take a while on slow systems. Give it plenty of time to sync.
161+
p2p1.sync_with_ping(timeout=960)
162162
assert_equal(self.nodes[1].getblock(self.nodes[1].getbestblockhash())['height'], 2202)
163163

164164
p2p2 = self.nodes[2].add_p2p_connection(BaseNode())

0 commit comments

Comments
 (0)