Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discussion: Handling of Event meta data (e.g. event number, run number, etc.) #241

Open
tmadlener opened this issue Nov 20, 2023 · 0 comments
Labels
discussion Discussion item

Comments

@tmadlener
Copy link
Contributor

Currently we have an edm4hep::EventHeader and we fill a collection using the edm4hep::EventHeaderName constant as a name.

static constexpr const char* EventHeaderName = "EventHeader";

While this is a workable solution, it has lead to a few issues / fixes related to this:

The major issue is that effectively that this approach has to necessarily build on some naming convention, and once they are fully established they became very hard to change even if there would be better approaches. Another smaller issue is the user side of the whole thing, where user code always looks something like this

auto evtHeaderColl = /* get event header coll from somewhere */
auto evtHeader = evtHeaderColl[0];

i.e. there is always an indexing operation necessary to get to the actual EventHeader that one is interested in.

If there is interest in a more "integrated" solution we could think about having a dedicated "identifier field" in the podio::Frame where some data can be stored and more easily accessed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion item
Projects
None yet
Development

No branches or pull requests

1 participant