Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate interface ? #216

Open
giovannimarchiori opened this issue Jul 25, 2024 · 1 comment
Open

Duplicate interface ? #216

giovannimarchiori opened this issue Jul 25, 2024 · 1 comment

Comments

@giovannimarchiori
Copy link
Contributor

It looks to me that INoiseConstTool and ICaloReadCellNoiseMap provide essentially the same interface, i.e. getters for noise RMS and offset given cellID - if that's the case we could get rid of one of the two (adjusting the code that uses one or the other)
@tmadlener
Copy link
Contributor

I haven't looked at either of them, but if it's possible to remove duplication I am all for it. If you are able to prepare a PR that removes one of them, I could check whatever breaks in other packages / downstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmadlener @giovannimarchiori