Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downstream consumer tests are no longer run? #246

Open
tmadlener opened this issue Oct 8, 2024 · 0 comments
Open

downstream consumer tests are no longer run? #246

tmadlener opened this issue Oct 8, 2024 · 0 comments

Comments

@tmadlener
Copy link
Contributor

tmadlener commented Oct 8, 2024

I just realized this in #230. It looks like the https://github.com/key4hep/k4FWCore/tree/main/test/downstream-project-cmake-test is no longer built in CI (and it has been like this for quite some time?)

I think in this project it would make sense to ensure that we don't break the downstream cmake config accidentally in CI.

edit: we technically have the downstream workflow that tests all currently used real world features, but given it's frequent unrelated failures, I think it would be useful to have a dedicated test

edit: We have the downstream build workflow that should cover all "real world use cases", but given that that has been rather flaky recently, I still think a dedicated small workflow (or addition to an existing workflow) would make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant