Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MarlinUtil HelixClass should not be used #31

Open
tmadlener opened this issue Aug 23, 2024 · 2 comments
Open

MarlinUtil HelixClass should not be used #31

tmadlener opened this issue Aug 23, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@tmadlener
Copy link
Contributor

I just discovered this via #29. The HelixClass from MarlinUtil has quite a few quirks and is ideally superseded by something a bit more sane and with fewer rough edges. For an extended discussion see MarlinUtil#24
@tmadlener tmadlener added the enhancement New feature or request label Aug 23, 2024
@BrieucF
Copy link
Collaborator

BrieucF commented Oct 11, 2024

Is there anything replacing this already?

@tmadlener
Copy link
Contributor Author

No, not really unfortunately. I think it is easiest to wait for ACTS and see whether we can reuse something from there. The main reason for opening this issue was to make people aware of the potential issues with the HelixClass. Ideally, we probably want to have some sort of abstraction here that acts as a kind of interface, but doesn't expose the details of what is underneath, such that we can "simply replace" that if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BrieucF @tmadlener