Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chromedriver prod dependency? #511

Open
winterec opened this issue Jan 2, 2024 · 1 comment
Open

Remove chromedriver prod dependency? #511

winterec opened this issue Jan 2, 2024 · 1 comment

Comments

@winterec
Copy link

winterec commented Jan 2, 2024

Describe the bug

chromedriver is being installed in my production builds with pnpm and turborepo. I can see that it's listed in optionalDependencies but it seems to be installed regardless and I can't seem to deselect it or create an override in pnpm.

Could this be safely moved to devDependencies?

pnpm-lock.yaml

  /[email protected]:
    resolution: {integrity: sha512-3aTU3m/hA9to6NhC1pLK6Rv/9zqJuvmX5J5C4LkKXF64ejQk/nlUnPw2hrBky+s6eJneFQ/sCWf4OSNGsenAYw==}
    engines: {node: '>=14'}
    dependencies:
      jwk-to-pem: 2.0.5
    optionalDependencies:
      chromedriver: 119.0.1
    transitivePeerDependencies:
      - debug
      - supports-color
    dev: false

Version

22.0.5

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Anything else?

No response

@jonkoops
Copy link
Contributor

jonkoops commented Jan 3, 2024

Yeah, this should be a devDependency instead, feel free to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants