Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sidekiq Enterprise/Pro #798

Open
ezekg opened this issue Feb 21, 2024 · 1 comment
Open

Add Sidekiq Enterprise/Pro #798

ezekg opened this issue Feb 21, 2024 · 1 comment

Comments

@ezekg
Copy link
Member

ezekg commented Feb 21, 2024

We will need to do this in a way that is opt-out, e.g. via an environment variable NO_SIDEKIQ_ENT and NO_SIDEKIQ_PRO, since the average Keygen CE installation will not pay for Sidekiq Enterprise or Sidekiq Pro.

Right now, the plan would be to replace both sidekiq-cron and sidekiq-unique-jobs with Sidekiq Enterprise's periodic and unique jobs, respectively, when it's available. When Sidekiq Enterprise is not available, we can keep sidekiq-cron, and maybe sidekiq-unique-jobs (if it's even really needed after fc1b739). When Sidekiq Pro is available but Sidekiq Enterprise is not, we can enable super_fetch and reliable_push, plus any other reliability enhancements.

@ezekg
Copy link
Member Author

ezekg commented May 25, 2024

Let's start out by removing sidekiq-unique-jobs because I'm still seeing performance issues related to Lua scripts from it, even after my fix (and I don't have the drive to debug it anymore). We no longer use it for anything mission critical, so might as well rip it out since it's just been causing problems and outages lately and has severely limited overall scalability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant