Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base64 encoding should be renamed to base64raw #21

Open
ezekg opened this issue Oct 28, 2024 · 0 comments
Open

Base64 encoding should be renamed to base64raw #21

ezekg opened this issue Oct 28, 2024 · 0 comments

Comments

@ezekg
Copy link
Member

ezekg commented Oct 28, 2024

Right now, base64 encoding via --checksum-encoding base64 and --signature-encoding base64 use Go's RawURLEncoding, which lacks padding. This doesn't play well with some tools, such as Rubygems. We should rename what is currently base64 to base64raw, keep it as the default, but also add base64 and base64url encoding options. This should be a backwards compatible change, since I doubt anybody is relying on an explicit base64 encoding, since it's already the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant